repl: eval empty lines, fixing debugger repeat #6025
Conversation
|
All tests pass other than parallel/test-tick-processor which was failing on master on my machine. Debugger repetition is tested in https://github.com/nodejs/node/blob/master/test/debugger/test-debugger-repl-term.js#L18-L23. With this fix the debugger tests no longer timeout, but there are multiple failures, presumably they have not been kept up to date. |
|
Yes, the debugger tests aren't run regularly; they're pretty flaky due to the nature of the debugger. I don't think this change is acceptable as-is because it changes all REPL behavior, not just the debugger's. The fix should probably be somewhere in If you can get |
|
This behaviour of the REPL with it's defaultEval should be unchanged. In order to prevent " I don't think it's possible to fix this from within the debugger since the REPLServers's I'll have a go at fixing the debugger tests. I wonder if the reliability problems were due to running multiple debugger tests in parallel when they all use the same port. |
Tweak the better empty line handling introduced in nodejs#2163 so that empty lines are still passed to the eval function. This is required for the debugger to repeat the last command on an empty line. Fixes: nodejs#6010
Matches current behaviour of Chrome devtools. PR-URL: nodejs#6025
Line numbers changed following comments cleanup in 3e1b1dd. PR-URL: nodejs#6025
Expected line now includes a prefix. PR-URL: nodejs#6025
lrowe
force-pushed
the
fix-debugger-repeat-6010
branch
from
c826ed8
to
4889017
Compare
|
The debugger tests all pass now. I need to work out how to run them in parallel to check reliability - I expect failures due to multiple tests using the same port. |
estliberitas
force-pushed
the
master
branch
2 times, most recently
from
7da4fd4
to
c7066fb
Compare
|
I believe the issue this is addressing has been fixed in 1df84f4. The issue should be resolved in Node.js 6.0.0 and newer. I'm going to close this, but If I'm mistaken/misunderstanding, please re-open. |
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
repl, debugger
Description of change
Tweak the better empty line handling introduced in #2163 so that empty lines
are still passed to the eval function. This is required for the debugger to
repeat the last command on an empty line.
Fixes: #6010